JonasJ-ap commented on code in PR #8144:
URL: https://github.com/apache/iceberg/pull/8144#discussion_r1277012522
##########
python/pyiceberg/io/pyarrow.py:
##########
@@ -724,6 +832,15 @@ def primitive(self, primitive: pa.DataType) -> IcebergType:
raise TypeError(f"Unsupported type: {primitive}")
+ def __init__(
+ self, projected_schema: Optional[Schema], match_with_field_name: bool
= False, ignore_unprojectable_fields: bool = False
Review Comment:
```suggestion
self, projected_schema: Optional[Schema] = None,
match_with_field_name: bool = False, ignore_unprojectable_fields: bool = False
```
With this change, all tests in `test_pyarrow_visitor.py` can pass without
any modification
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
