rdsr commented on a change in pull request #939:
URL: https://github.com/apache/incubator-iceberg/pull/939#discussion_r415129062
##########
File path: core/src/main/java/org/apache/iceberg/FastAppend.java
##########
@@ -49,7 +49,8 @@
private ManifestFile newManifest = null;
private boolean hasNewFiles = false;
- FastAppend(TableOperations ops) {
+ FastAppend(String tableName, TableOperations ops) {
+ //TODO we use tableName to publish notification
Review comment:
So `FastAppend` extends `SnapshotProducer` . If I change
`SnapshotProducer`, I'll have to change `BaseRewriteManifests`. OK to make that
change in this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
