RussellSpitzer commented on issue #8255: URL: https://github.com/apache/iceberg/issues/8255#issuecomment-1669672686
I'm going to agree with @zhongyujiang. We generally do not want to add the same file to the table multiple times regardless of deletes. I think we don't explicitly write this out yet but there are several behaviors which will lead to weird results if the same file is included multiple times in a table. That said, I actually think the Spark Algorithm (see [Expire Snapshots Action](https://github.com/apache/iceberg/blob/master/spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/actions/ExpireSnapshotsSparkAction.java#L164-L172)) would be safe for this execution since it takes the diff between the before and after expire action rather than trying to enumerate deleted files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
