hililiwei commented on code in PR #8250:
URL: https://github.com/apache/iceberg/pull/8250#discussion_r1287852686
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/InternalRowWrapper.java:
##########
@@ -71,8 +77,12 @@ public <T> void set(int pos, T value) {
row.update(pos, value);
}
- private static BiFunction<InternalRow, Integer, ?> getter(DataType type) {
+ private static BiFunction<InternalRow, Integer, ?> getter(Type icebergType,
DataType type) {
Review Comment:
nit: Do we rename the `type` to make it clear that it is `sql type` of spark?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
