rdblue commented on a change in pull request #983:
URL: https://github.com/apache/incubator-iceberg/pull/983#discussion_r417466810
##########
File path: api/src/test/java/org/apache/iceberg/transforms/TestResiduals.java
##########
@@ -191,26 +191,18 @@ public void testInTimestamp() {
Types.NestedField.optional(51, "dateint", Types.IntegerType.get())
);
- Long date20191201 = (Long) Literal.of("2019-12-01T00:00:00.00000")
- .to(Types.TimestampType.withoutZone()).value();
- Long date20191202 = (Long) Literal.of("2019-12-02T00:00:00.00000")
- .to(Types.TimestampType.withoutZone()).value();
-
PartitionSpec spec = PartitionSpec.builderFor(schema)
.day("ts")
.build();
- Transform day = spec.getFieldsBySourceId(50).get(0).transform();
- Integer tsDay = (Integer) day.apply(date20191201);
-
- Predicate pred = in("ts", date20191201, date20191202);
+ Predicate pred = in("ts", "2019-12-01T00:00:00.00000",
"2019-12-01T00:00:00.00000");
Review comment:
Why were these changes necessary?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
