nastra commented on code in PR #8380:
URL: https://github.com/apache/iceberg/pull/8380#discussion_r1310376544
##########
core/src/test/java/org/apache/iceberg/avro/TestAvroNameMapping.java:
##########
@@ -369,15 +377,15 @@ protected Record writeAndRead(
Record record = super.writeAndRead(desc, writeSchema, readSchema,
inputRecord);
Record projectedWithNameMapping =
writeAndRead(writeSchema, readSchema, inputRecord,
MappingUtil.create(writeSchema));
- Assert.assertEquals(record, projectedWithNameMapping);
+ Assertions.assertThat(projectedWithNameMapping).isEqualTo(record);
return record;
}
private Record writeAndRead(
Schema writeSchema, Schema readSchema, Record record, NameMapping
nameMapping)
throws IOException {
- File file = temp.newFile();
+ File file = new File(temp, "test.avro");
Review Comment:
should this be handled similarly to
https://github.com/apache/iceberg/pull/8056/files#diff-d4debd1e3696fc5a7684ef1cf178c7d100aedfad26ffbca0560038eb98e90487R98?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
