Xuanwo commented on code in PR #53:
URL: https://github.com/apache/iceberg-rust/pull/53#discussion_r1312547378
##########
crates/iceberg/src/error.rs:
##########
@@ -44,6 +44,10 @@ pub enum ErrorKind {
///
/// This error is returned when given iceberg feature is not supported.
FeatureUnsupported,
+ /// Error during io operation.
+ ///
+ /// This error is returned when doing io operations.
+ IoError,
Review Comment:
`IoError` is too general that no action can take. There are two error kind
we can add there at least:
- `TableNotFound`: Table is not exist.
- `TablePermissionDenial`: User doesn't have enough permission to operate on
this table.
Other errors can be treated as `Unexpected` until we find users may need to
handle them.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
