rdblue commented on code in PR #8123:
URL: https://github.com/apache/iceberg/pull/8123#discussion_r1315102154
##########
core/src/main/java/org/apache/iceberg/ManifestGroup.java:
##########
@@ -222,6 +223,19 @@ public CloseableIterable<ManifestEntry<DataFile>>
entries() {
return CloseableIterable.concat(entries((manifest, entries) -> entries));
}
+ /**
+ * Returns an iterable for groups of data files in the set of manifests.
+ *
+ * <p>Files are not copied, it is the caller's responsibility to make
defensive copies if adding
+ * these files to a collection.
+ *
+ * @return an iterable of file groups
+ */
+ public Iterable<CloseableIterable<DataFile>> fileGroups() {
Review Comment:
Why is this called `fileGroups`? It looks like it produces the file from
every entry, not a group.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
