rdblue commented on code in PR #6004:
URL: https://github.com/apache/iceberg/pull/6004#discussion_r1315122597
##########
.palantir/revapi.yml:
##########
@@ -451,6 +451,15 @@ acceptedBreaks:
- code: "java.field.removedWithConstant"
old: "field org.apache.iceberg.TableProperties.HMS_TABLE_OWNER"
justification: "Removing deprecations for 1.3.0"
+ - code: "java.method.numberOfParametersChanged"
+ old: "method void
org.apache.iceberg.avro.ValueReaders.StructReader<S>::<init>(java.util.List<org.apache.iceberg.avro.ValueReader<?>>,\
+ \ org.apache.iceberg.types.Types.StructType,
java.util.Map<java.lang.Integer,\
+ \ ?>)"
+ new: "method void
org.apache.iceberg.avro.ValueReaders.StructReader<S>::<init>(java.util.List<org.apache.iceberg.avro.ValueReader<?>>,\
Review Comment:
There's no need to break compatibility. Can you add a constructor that
defaults the `idToDefault` map to `ImmutableMap.of()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
