jerqi commented on PR #8428: URL: https://github.com/apache/iceberg/pull/8428#issuecomment-1708174766
> @jerqi sorry about this, I was re-thinking about it and not 100% sure it makes sense, as there are some table properties that look weird on all metadata tables. > > What do you think about first trying to solve it in [SparkBinPackPositionDeletesRewriter] (using ds write options) (https://github.com/apache/iceberg/blob/master/spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/actions/SparkBinPackPositionDeletesRewriter.java) I think that's a bit less impact. The properties of PositionDeletesTable is empty. There are many properties will be useful to write data. ``` write.delete.orc.compression-codec write.delete.parquet.row-group-check-max-record-count write.parquet.bloom-filter-enable ...... ``` We need to set every write option for the data frame. It may be difficult for users to use. What about my second solution? We only modify the properties of PositionDeletesTable. We can filter out the unreasonable table property. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
