amogh-jahagirdar commented on code in PR #8397:
URL: https://github.com/apache/iceberg/pull/8397#discussion_r1318885267
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -380,14 +375,9 @@ private void commitReplaceTransaction(boolean orCreate) {
} catch (RuntimeException e) {
// the commit failed and no files were committed. clean up each update.
- Tasks.foreach(updates)
- .suppressFailureWhenFinished()
- .run(
- update -> {
- if (update instanceof SnapshotProducer) {
- ((SnapshotProducer) update).cleanAll();
- }
- });
+ if (!ops.requireStrictCleanup() || e instanceof CleanableFailure) {
+ cleanUpOnCommitFailure();
Review Comment:
Ah the delete is best effort so the second time when the file no longer
exists the delete would fail but we catch it and emit a warn log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
