nastra commented on code in PR #8617:
URL: https://github.com/apache/iceberg/pull/8617#discussion_r1333857399


##########
.palantir/revapi.yml:
##########
@@ -833,6 +829,13 @@ acceptedBreaks:
     - code: "java.class.removed"
       old: "interface org.apache.iceberg.actions.RewritePositionDeleteStrategy"
       justification: "Removing deprecated code"
+    - code: "java.method.abstractMethodAdded"

Review Comment:
   we shouldn't be breaking the API. See also my comment in 
https://github.com/apache/iceberg/pull/6799#discussion_r1108121835 on how to 
avoid breaking the API for adding the new method



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to