jbonofre commented on code in PR #8612:
URL: https://github.com/apache/iceberg/pull/8612#discussion_r1334133044
##########
aws/src/main/java/org/apache/iceberg/aws/AwsClientProperties.java:
##########
@@ -57,7 +57,7 @@ public class AwsClientProperties implements Serializable {
* classes to pass provider-specific properties. Each property consists of a
key name and an
* associated value.
*/
- private static final String CLIENT_CREDENTIAL_PROVIDER_PREFIX =
"client.credentials-provider.";
+ protected static final String CLIENT_CREDENTIAL_PROVIDER_PREFIX =
"client.credentials-provider.";
Review Comment:
@Fokko @nastra if I remove `clientCredentialsProvider` from `AwsProperties`,
I have to remove `AwsProperties#applyClientCredentialConfigurations()` method
(to use the one defined in `AwsClientProperties`).
However, `AwsProperties#applyClientCredentialConfigurations()` is not
flagged as `@Deprecated`.
I propose to just change the visibility of
`CLIENT_CREDENTIAL_PROVIDER_PREFIX` in `AwsClientProperties` for now, and flag
`AwsProperties#applyClientCredentialConfigurations()` with `@Deprecated` for
2.0.0 (and I will remove at that time).
Thoughts ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
