Fokko commented on code in PR #8659:
URL: https://github.com/apache/iceberg/pull/8659#discussion_r1340445915
##########
docs-new/.github/workflows/ci.yml:
##########
@@ -0,0 +1,29 @@
+name: ci
+on:
+ push:
+ branches:
+ - master
Review Comment:
Alright, then you should not run the workflow on a `push` event on the
main/master branch.
Then you want to replace it with:
```yaml
on:
tags:
- apache-iceberg-*
```
Also, in PyIceberg we have it as a [step in the
release](https://py.iceberg.apache.org/how-to-release/#release-the-docs):
https://github.com/apache/iceberg/blob/eaf7c4f2e2adc952b5a150cf0b854adebfb9fdf0/.github/workflows/python-ci-docs.yml#L21-L22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
