rdblue commented on PR #8259: URL: https://github.com/apache/iceberg/pull/8259#issuecomment-1740103438
@advancedxy, thanks for your patience on this. I'm going to be looking at it more once the 1.4 release is out. I have a couple of things that I'm thinking through on this: * If we're updating the function, should we use a faster algorithm like XXH? * Should we use a different approach to get to a bucket number rather than modulus? * Should we make hash(str) and hash(int) the same to enable type promotion? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
