amogh-jahagirdar commented on code in PR #8677:
URL: https://github.com/apache/iceberg/pull/8677#discussion_r1341987133
##########
aws/src/main/java/org/apache/iceberg/aws/AwsClientFactories.java:
##########
@@ -226,7 +226,7 @@ static AwsCredentialsProvider credentialsProvider(
AwsSessionCredentials.create(accessKeyId, secretAccessKey,
sessionToken));
}
} else {
- return DefaultCredentialsProvider.create();
+ return DefaultCredentialsProvider.builder().build();
Review Comment:
Nit: Maybe have an inline comment along the lines of "Create a new
credential provider for each client"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
