Fokko commented on code in PR #40:
URL: https://github.com/apache/iceberg-python/pull/40#discussion_r1345991299
##########
pyiceberg/manifest.py:
##########
@@ -262,15 +346,13 @@ class DataFile(Record):
"split_offsets",
"equality_ids",
"sort_order_id",
- "spec_id",
)
content: DataFileContent
file_path: str
file_format: FileFormat
partition: Record
record_count: int
file_size_in_bytes: int
- block_size_in_bytes: Optional[int]
Review Comment:
I've removed this since we shouldn't use it. It is still part of the schema
itself.
##########
pyiceberg/manifest.py:
##########
@@ -281,7 +363,6 @@ class DataFile(Record):
split_offsets: Optional[List[int]]
equality_ids: Optional[List[int]]
sort_order_id: Optional[int]
- spec_id: Optional[int]
Review Comment:
Removed this for now. Created an issue:
https://github.com/apache/iceberg/issues/8712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
