ajantha-bhat commented on code in PR #8722:
URL: https://github.com/apache/iceberg/pull/8722#discussion_r1347108071
##########
docs/metrics-reporting.md:
##########
@@ -171,4 +171,4 @@ TableScan tableScan =
try (CloseableIterable<FileScanTask> fileScanTasks = tableScan.planFiles()) {
// ...
}
-```
\ No newline at end of file
+```
Review Comment:
same here.
##########
docs/flink-writes.md:
##########
@@ -270,4 +270,4 @@ INSERT INTO tableName /*+ OPTIONS('upsert-enabled'='true')
*/
...
```
-Check out all the options here:
[write-options](/flink-configuration#write-options)
Review Comment:
nit: why these are shown as modified? Shall we revert the unrelated changed?
##########
.github/workflows/spark-ci.yml:
##########
@@ -143,4 +143,4 @@ jobs:
with:
name: test logs
path: |
- **/build/testlogs
\ No newline at end of file
+ **/build/testlogs
Review Comment:
nit: unrelated modification?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]