amogh-jahagirdar commented on code in PR #8723:
URL: https://github.com/apache/iceberg/pull/8723#discussion_r1347436052
##########
core/src/main/java/org/apache/iceberg/view/ViewMetadataParser.java:
##########
@@ -66,7 +67,9 @@ static void toJson(ViewMetadata metadata, JsonGenerator gen)
throws IOException
gen.writeStringField(VIEW_UUID, metadata.uuid());
gen.writeNumberField(FORMAT_VERSION, metadata.formatVersion());
gen.writeStringField(LOCATION, metadata.location());
- JsonUtil.writeStringMap(PROPERTIES, metadata.properties(), gen);
+ if (!metadata.properties().isEmpty()) {
Review Comment:
Just discussed with @nastra , I also see the other argument that writing
empty collections is a bit wasteful. Considering that, I'm okay either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
