rdblue commented on code in PR #8730:
URL: https://github.com/apache/iceberg/pull/8730#discussion_r1349759341
##########
format/spec.md:
##########
@@ -443,13 +443,13 @@ The schema of a manifest file is a struct called
`manifest_entry` with the follo
| _optional_ | _optional_ | **`132 split_offsets`** | `list<133:
long>` | Split offsets for the data file. For example, all row group
offsets in a Parquet file. Must be sorted ascending |
| | _optional_ | **`135 equality_ids`** | `list<136:
int>` | Field ids used to determine row equality in equality delete
files. Required when `content=2` and should be null otherwise. Fields with ids
listed in this column must be present in the delete file |
| _optional_ | _optional_ | **`140 sort_order_id`** | `int`
| ID representing sort order for this file [3]. |
-
+| _optional_ | _optional_ | **`141 spec_id`** | `int`
| ID representing partition spec for this file [4]. |
Review Comment:
This isn't optional. The field ID is reserved, but it should never be
written to a metadata file.
We need to reserve an ID for it because it is present in metadata tables. We
don't want to have conflicting IDs when reading these files. I think all we
need to communicate is that no one should write any field with ID 141, which is
why we noted it was reserved here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
