aokolnychyi commented on code in PR #8755:
URL: https://github.com/apache/iceberg/pull/8755#discussion_r1350602336
##########
data/src/main/java/org/apache/iceberg/data/DeleteFilter.java:
##########
@@ -243,20 +236,9 @@ private CloseableIterable<T>
applyPosDeletes(CloseableIterable<T> records) {
return records;
}
- List<CloseableIterable<Record>> deletes = Lists.transform(posDeletes,
this::openPosDeletes);
-
- // if there are fewer deletes than a reasonable number to keep in memory,
use a set
- if (posDeletes.stream().mapToLong(DeleteFile::recordCount).sum() <
setFilterThreshold) {
- PositionDeleteIndex positionIndex = Deletes.toPositionIndex(filePath,
deletes);
- Predicate<T> isDeleted = record -> positionIndex.isDeleted(pos(record));
- return createDeleteIterable(records, isDeleted);
- }
-
- return hasIsDeletedColumn
Review Comment:
This is a separate discussion but I think we should drop streaming position
deletes. We originally added them when we used a set, not bitmaps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
