ajantha-bhat commented on code in PR #8798:
URL: https://github.com/apache/iceberg/pull/8798#discussion_r1356770832
##########
nessie/src/test/java/org/apache/iceberg/nessie/TestCustomNessieClient.java:
##########
@@ -78,30 +77,11 @@ public void testNonExistentCustomClient() {
temp.toUri().toString(),
CatalogProperties.URI,
uri,
- NessieConfigConstants.CONF_NESSIE_CLIENT_BUILDER_IMPL,
- "non.existent.ClientBuilderImpl"));
- })
- .isInstanceOf(RuntimeException.class)
- .hasMessageContaining("Cannot load Nessie client builder
implementation class");
- }
-
- @Test
- public void testCustomClientByImpl() {
Review Comment:
Since CONF_NESSIE_CLIENT_BUILDER_IMPL is deprecated, we need change testcase
to use CONF_NESSIE_CLIENT_NAME instead of removing. But there is already a
testcase to do that. So, I guess he removed the testcase of
CONF_NESSIE_CLIENT_BUILDER_IMPL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
