nk1506 commented on PR #8798: URL: https://github.com/apache/iceberg/pull/8798#issuecomment-1759595831
> nit: `Adopt` -> `Adapt` in title? > > I believe the removed test case is worth keeping. Since `CONF_NESSIE_CLIENT_BUILDER_IMPL` has been deprecated, replacing it with `CONF_NESSIE_CLIENT_NAME` will make [testCustomClientByImpl](https://github.com/apache/iceberg/blob/b5ea0d5a7f55e5b8d9eec8e764bbcc35f8301db3/nessie/src/test/java/org/apache/iceberg/nessie/TestCustomNessieClient.java#L89 ) and [testCustomClientByName](https://github.com/apache/iceberg/blob/b5ea0d5a7f55e5b8d9eec8e764bbcc35f8301db3/nessie/src/test/java/org/apache/iceberg/nessie/TestCustomNessieClient.java#L108) duplicate of each other. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
