nastra commented on code in PR #8819:
URL: https://github.com/apache/iceberg/pull/8819#discussion_r1358006481
##########
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogNamespace.java:
##########
@@ -105,7 +105,7 @@ public void testNamespaceExists() {
public void testListNamespace() {
String namespace = createNamespace();
List<Namespace> namespaceList = glueCatalog.listNamespaces();
- Assert.assertTrue(namespaceList.size() > 0);
+ Assert.assertFalse(namespaceList.isEmpty());
Review Comment:
nit: we might want to switch all Junit4-style assertions to AssertJ in the
AWS integration test module (in a separate PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
