amogh-jahagirdar commented on code in PR #65:
URL: https://github.com/apache/iceberg-python/pull/65#discussion_r1358113965
##########
pyiceberg/expressions/parser.py:
##########
@@ -233,10 +233,14 @@ def handle_not(result: ParseResults) -> Not:
def handle_and(result: ParseResults) -> And:
+ if len(result[0]) > 2:
+ return And(result[0][0], result[0][1], *result[0][2:])
return And(result[0][0], result[0][1])
Review Comment:
Uh maybe not the most pythonic...I guess a ternary which sets the *args
option if it's > 2 otherwise AlwaysTrue (for And) and then for Or would be
AlwaysFalse so it just considers the first 2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
