JanKaul commented on code in PR #78:
URL: https://github.com/apache/iceberg-rust/pull/78#discussion_r1360172363


##########
crates/iceberg/Cargo.toml:
##########
@@ -41,20 +41,24 @@ either = "1"
 futures = "0.3"
 itertools = "0.11"
 lazy_static = "1"
+log = "^0.4"
 murmur3 = "0.5.2"
 once_cell = "1"
 opendal = "0.40"
 ordered-float = "4.0.0"
+reqwest = { version = "^0.11", features = ["json"] }

Review Comment:
   I'm also in favor of using a separate crate for the rest catalog. This way 
we avoid bringing in dependencies for catalogs that don't need them and that 
might prevent the crate from compiling, like wasm/wasi for example.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to