zhangminglei commented on code in PR #8844:
URL: https://github.com/apache/iceberg/pull/8844#discussion_r1360727462
##########
core/src/main/java/org/apache/iceberg/CachingCatalog.java:
##########
@@ -110,6 +110,8 @@ private Cache<TableIdentifier, Table>
createTableCache(Ticker ticker) {
.removalListener(new MetadataTableInvalidatingRemovalListener())
.executor(Runnable::run) // Makes the callbacks to removal listener
synchronous
.expireAfterAccess(Duration.ofMillis(expirationIntervalMillis))
+ .expireAfterWrite(
Review Comment:
In fact, my local code does not have `expireAfterAccess`. I kept
`expireAfterAccess` to see how reviewer thinks about this problem. I set the
`expireAfterWrite` time to be longer than `expireAfterAccess` because I want to
use it as a cache ttl.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
