ajantha-bhat commented on issue #8849: URL: https://github.com/apache/iceberg/issues/8849#issuecomment-1765789016
Hmm, It is not just the null check addition in the procedure, later it fails because reference MAIN does not exist during replace branch. https://github.com/apache/iceberg/blob/46cad6ddaeff8104d96defab25206a4ff7e01629/core/src/main/java/org/apache/iceberg/UpdateSnapshotReferencesOperation.java#L123 The reason is we create the main branch only during first snapshot creation. But in this scenario there is no main branch exist for replace operation. I thought of blocking this scenario by throwing an exception. But since we support creating empty branch (from https://github.com/apache/iceberg/pull/8072/), we should also support replacing to/from empty branch. I am thinking to add an empty/dummy snapshot for create table operation with MAIN reference in a sparate PR to tackle this. Let me know what you guys think, @amogh-jahagirdar, @ConeyLiu , @rdblue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
