JanKaul commented on code in PR #80:
URL: https://github.com/apache/iceberg-rust/pull/80#discussion_r1361690259
##########
crates/iceberg/src/spec/values.rs:
##########
@@ -995,7 +995,7 @@ mod tests {
assert_eq!(literal, expected_literal);
let mut writer = apache_avro::Writer::new(&schema, Vec::new());
- writer.append_ser(bytes).unwrap();
+ writer.append_ser(Into::<ByteBuf>::into(literal)).unwrap();
Review Comment:
There is a `ByteBuf::from(value: impl Into<Vec<u8>>)` which overrides the
`From<Literal>` for `ByteBuf` and I need to somehow specify that I want the
conversion from `Literal` to `ByteBuf`. Maybe you know of a different way to
specify which `form/into` implementation to use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
