rakesh-das08 commented on code in PR #8854:
URL: https://github.com/apache/iceberg/pull/8854#discussion_r1362071081
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/FastForwardBranchProcedure.java:
##########
@@ -77,9 +77,9 @@ public InternalRow[] call(InternalRow args) {
return modifyIcebergTable(
tableIdent,
table -> {
- long currentRef = table.currentSnapshot().snapshotId();
+ long currentRef = table.snapshot(source).snapshotId();
Review Comment:
I had thought of this case where we could introduce a dummy snapshot, but as
you mentioned, it did not look like an elegant solution. And with this PR :
https://github.com/apache/iceberg/pull/7652/ , i just basically fall back to
the underlying replace operation to throw an appropriate exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
