chenjunjiedada commented on a change in pull request #830:
URL: https://github.com/apache/incubator-iceberg/pull/830#discussion_r429509232
##########
File path:
parquet/src/main/java/org/apache/iceberg/parquet/ParquetDictionaryRowGroupFilter.java
##########
@@ -108,11 +118,15 @@ private boolean eval(MessageType fileSchema,
BlockMetaData rowGroup,
}
for (ColumnChunkMetaData meta : rowGroup.getColumns()) {
- PrimitiveType colType =
fileSchema.getType(meta.getPath().toArray()).asPrimitiveType();
- if (colType.getId() != null) {
- int id = colType.getId().intValue();
- isFallback.put(id, ParquetUtil.hasNonDictionaryPages(meta));
- mayContainNulls.put(id, mayContainNull(meta));
+ try {
+ PrimitiveType colType =
fileSchema.getType(meta.getPath().toArray()).asPrimitiveType();
+ if (colType.getId() != null) {
+ int id = colType.getId().intValue();
+ isFallback.put(id, ParquetUtil.hasNonDictionaryPages(meta));
+ mayContainNulls.put(id, mayContainNull(meta));
+ }
+ } catch (org.apache.parquet.io.InvalidRecordException e) {
Review comment:
`SparkParquetReader` build parquet reader according to `typeWithIds`
passed from ReadConf.java. The `HasId` is used in ReadConf.java to assign IDs
to file schema, and then it is used in `SparkParquetReader` to determine
whether passing files schema has assigned IDs.
Besides `PruneColumsn`, The `ReadBuilder` also assumes all IDs assigned.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
