rdblue commented on code in PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#discussion_r1367147296
##########
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##########
@@ -604,6 +604,27 @@ public void testCreateNamespace() {
// Test with no metadata
catalog.createNamespace(testNamespace);
assertThat(catalog.namespaceExists(testNamespace)).isTrue();
+ assertThat(catalog.namespaceExists(Namespace.of("testDb"))).isTrue();
+ assertThat(catalog.namespaceExists(Namespace.of("testDb",
"ns1"))).isTrue();
+ assertThat(catalog.namespaceExists(Namespace.of("testDb", "ns1",
"ns2"))).isTrue();
+ assertThat(catalog.namespaceExists(Namespace.of("testDb_"))).isFalse();
+ assertThat(catalog.namespaceExists(Namespace.of("testD_"))).isFalse();
+ assertThat(catalog.namespaceExists(Namespace.of("testDb."))).isFalse();
+ assertThat(catalog.namespaceExists(Namespace.of("testDb.ns"))).isFalse();
+ assertThat(catalog.namespaceExists(Namespace.of("testDb.ns_"))).isFalse();
+ assertThat(catalog.namespaceExists(Namespace.of("testDb%"))).isFalse();
Review Comment:
For these false cases, can you run them twice? Once like this and once with
a namespace that would match if the special character were not escaped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
