pvary commented on code in PR #8803:
URL: https://github.com/apache/iceberg/pull/8803#discussion_r1369764771
##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/FlinkReadConf.java:
##########
@@ -152,6 +155,16 @@ public boolean includeColumnStats() {
.parse();
}
+ public Set<Integer> columnStatsToKeep() {
+ return split(
Review Comment:
Might need stats for previous versions of columns (old files contain old
stats for old columns).
Removed for now anyway
##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/ScanContext.java:
##########
@@ -464,6 +476,11 @@ public Builder includeColumnStats(boolean
newIncludeColumnStats) {
return this;
}
+ public Builder columnStatsToKeep(Set<Integer> newColumnStatsToKeep) {
Review Comment:
Fixed everywhere (I hope, will check).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
