Fokko commented on code in PR #94:
URL: https://github.com/apache/iceberg-python/pull/94#discussion_r1370091939
##########
pyiceberg/expressions/__init__.py:
##########
@@ -701,7 +701,7 @@ def bind(self, schema: Schema, case_sensitive: bool = True)
-> BoundLiteralPredi
def __eq__(self, other: Any) -> bool:
"""Return the equality of two instances of the LiteralPredicate
class."""
- if isinstance(other, LiteralPredicate):
+ if isinstance(other, self.__class__):
Review Comment:
Raised a PR https://github.com/danielcweeks/iceberg-python/pull/1 to get
these fixed :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
