rdblue commented on code in PR #8803:
URL: https://github.com/apache/iceberg/pull/8803#discussion_r1375315462
##########
core/src/main/java/org/apache/iceberg/V2Metadata.java:
##########
@@ -560,6 +561,11 @@ public F copy() {
throw new UnsupportedOperationException("Cannot copy IndexedDataFile
wrapper");
}
+ @Override
+ public F copyWithStats(Set<Integer> columnsToKeepStats) {
Review Comment:
I think it is debatable whether to use `String` or `Integer` here. Clearly,
`Integer` is easier but why should the API expose column IDs? I suspect that
this should be `String` unless there is something that makes it far more
difficult.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
