nastra commented on code in PR #8920:
URL: https://github.com/apache/iceberg/pull/8920#discussion_r1375905299
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -939,7 +967,12 @@ private static Cache<String, AuthSession>
newSessionCache(Map<String, String> pr
return Caffeine.newBuilder()
.expireAfterAccess(Duration.ofMillis(expirationIntervalMs))
.removalListener(
- (RemovalListener<String, AuthSession>) (id, auth, cause) ->
auth.stopRefreshing())
+ (RemovalListener<String, AuthSession>)
+ (id, auth, cause) -> {
+ if (null != auth) {
Review Comment:
it wasn't strictly necessary, but we've been doing null checks in all other
instances of such a cache. I've reverted that change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
