nastra commented on code in PR #8937:
URL: https://github.com/apache/iceberg/pull/8937#discussion_r1376028283
##########
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogCommitFailure.java:
##########
@@ -84,12 +81,10 @@ public void testFailedCommitThrowsUnknownException() {
GlueTableOperations spyOps = Mockito.spy(ops);
failCommitAndThrowException(spyOps);
-
- AssertHelpers.assertThrows(
- "Should throw CommitStateUnknownException since exception is
unexpected",
- CommitStateUnknownException.class,
- "Datacenter on fire",
- () -> spyOps.commit(metadataV2, metadataV1));
+ Assertions.assertThatThrownBy(() -> spyOps.commit(metadataV2, metadataV1))
+ .as("Should throw CommitStateUnknownException since exception is
unexpected")
Review Comment:
not needed
##########
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogCommitFailure.java:
##########
@@ -61,12 +60,10 @@ public void testFailedCommit() {
GlueTableOperations spyOps = Mockito.spy(ops);
failCommitAndThrowException(spyOps, new CommitFailedException("Datacenter
on fire"));
-
- AssertHelpers.assertThrows(
- "Commit failed exception should directly throw",
- CommitFailedException.class,
- "Datacenter on fire",
- () -> spyOps.commit(metadataV2, metadataV1));
+ Assertions.assertThatThrownBy(() -> spyOps.commit(metadataV2, metadataV1))
+ .as("Commit failed exception should directly throw")
Review Comment:
not needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
