bitsondatadev commented on code in PR #8919:
URL: https://github.com/apache/iceberg/pull/8919#discussion_r1378304225
##########
site/README.md:
##########
@@ -125,17 +124,16 @@ mkdocs serve
## Release process
Deploying a version of the docs is a two step process:
- 1. ~~Cut a new release from the current branch revision. This creates a new
branch `docs-<version>`.~~
+ 1. ~~Release a new version by copying the current nightly directory to a new
version directory in the `docs` branch.~~
```
.github/bin/deploy_docs.sh -v 1.4.0
Review Comment:
Yeah,
I had a discussion with @rdblue that we should add deploy scripts in this PR
and not have the script that I added where if run in the wrong directory did
bad things 😬.
https://github.com/apache/iceberg/pull/8659#discussion_r1367561171
##########
site/README.md:
##########
@@ -125,17 +124,16 @@ mkdocs serve
## Release process
Deploying a version of the docs is a two step process:
- 1. ~~Cut a new release from the current branch revision. This creates a new
branch `docs-<version>`.~~
+ 1. ~~Release a new version by copying the current nightly directory to a new
version directory in the `docs` branch.~~
```
.github/bin/deploy_docs.sh -v 1.4.0
Review Comment:
Yeah,
I had a discussion with @rdblue that we should add deploy scripts in this PR
and not have the script that I added where if run in the wrong directory did
bad things 😬.
https://github.com/apache/iceberg/pull/8659#discussion_r1367561171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
