aokolnychyi commented on code in PR #8717:
URL: https://github.com/apache/iceberg/pull/8717#discussion_r1379552388
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkScan.java:
##########
@@ -200,12 +220,31 @@ public CustomTaskMetric[] reportDriverMetrics() {
}
List<CustomTaskMetric> driverMetrics = Lists.newArrayList();
Review Comment:
Minor: Can we add an empty line after this one and before `// common`?
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkScan.java:
##########
@@ -200,12 +220,31 @@ public CustomTaskMetric[] reportDriverMetrics() {
}
List<CustomTaskMetric> driverMetrics = Lists.newArrayList();
+ // common
driverMetrics.add(TaskTotalFileSize.from(scanReport));
Review Comment:
Could you confirm `TaskTotalFileSize` represents the total size of read data?
If so, shall we call these metrics as `TaskTotalDataFileSize` and
`TotalDataFileSize`? I know we follow the API from core but it seems a bit
confusing. I had to look up the code to understand what this metric means. If
we decide to rename, let's move it to the data files block below.
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/metrics/TotalDeleteFileSize.java:
##########
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iceberg.spark.source.metrics;
+
+import org.apache.spark.sql.connector.metric.CustomSumMetric;
+
+public class TotalDeleteFileSize extends CustomSumMetric {
+
+ static final String NAME = "totalDeleteFileSize";
+
+ @Override
+ public String name() {
+ return NAME;
+ }
+
+ @Override
+ public String description() {
+ return "total delete file size in bytes";
Review Comment:
Let's follow what we have in `TotalFileSize` where use `... (bytes)` instead
of `... in bytes`.
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkScan.java:
##########
@@ -215,12 +254,32 @@ public CustomMetric[] supportedCustomMetrics() {
return new CustomMetric[] {
new NumSplits(),
Review Comment:
Minor: Can we add ``// task metrics`` before this line?
Both `NumSplits` and `NumDeletes` are populated at the task level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
