aokolnychyi commented on code in PR #8959:
URL: https://github.com/apache/iceberg/pull/8959#discussion_r1380975737
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteManifestsSparkAction.java:
##########
@@ -73,8 +73,10 @@
*
* <p>By default, this action rewrites all manifests for the current partition
spec and writes the
* result to the metadata folder. The behavior can be modified by passing a
custom predicate to
- * {@link #rewriteIf(Predicate)} and a custom spec id to {@link #specId(int)}.
In addition, there is
- * a way to configure a custom location for new manifests via {@link
#stagingLocation}.
+ * {@link #rewriteIf(Predicate)} and a custom spec ID to {@link #specId(int)}.
In addition, there is
+ * a way to configure a custom location for staged manifests via {@link
#stagingLocation(String)}.
+ * The provided staging location will be ignored if new manifests are
committed directly. In such
Review Comment:
I agree, updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
