Fokko commented on code in PR #117:
URL: https://github.com/apache/iceberg-python/pull/117#discussion_r1381820634
##########
pyiceberg/io/pyarrow.py:
##########
@@ -435,13 +435,18 @@ def delete(self, location: Union[str, InputFile,
OutputFile]) -> None:
raise # pragma: no cover - If some other kind of OSError, raise
the raw error
-def schema_to_pyarrow(schema: Union[Schema, IcebergType]) -> pa.schema:
- return visit(schema, _ConvertToArrowSchema())
+def schema_to_pyarrow(schema: Union[Schema, IcebergType], metadata:
Dict[bytes, bytes] = EMPTY_DICT) -> pa.schema:
+ return visit(schema, _ConvertToArrowSchema(metadata))
Review Comment:
Sometime we use the visitor to convert types, then we don't need to set any
metadata so then a default with an empty dict makes things easier and less
verbose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
