waifairer commented on code in PR #104:
URL: https://github.com/apache/iceberg-python/pull/104#discussion_r1383886741
##########
mkdocs/docs/configuration.md:
##########
@@ -195,6 +195,19 @@ catalog:
table-name: iceberg
```
+If you prefer to pass the credentials explicitly to the client instead of
relying on environment variables,
+
+```yaml
+catalog:
+ default:
+ type: dynamodb
+ table-name: iceberg
Review Comment:
@HonahX Definitely agreed with `dynamo` as a prefix.
As for hyphens vs underscores, AWS is _really_ consistent about using
underscores. I'm of the opinion that the AWS-based credentials should support
both underscores and hyphens, will prefer hyphens if present, but fall back to
the underscore usages if necessary. Documentation should only present the
hyphenated case as an option. I believe that this strategy would lead to the
least number of "head banging" debug sessions. However, I think a reasonable
case could be made to remove underscore support instead of supporting it as a
fallback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
