massdosage commented on a change in pull request #1076:
URL: https://github.com/apache/iceberg/pull/1076#discussion_r432425247
##########
File path: .baseline/checkstyle/checkstyle.xml
##########
@@ -165,6 +165,11 @@
<property name="illegalClasses"
value="com.google.common.base.Optional, com.google.common.base.Supplier"/>
<message key="import.illegal" value="Use the Java8 version of
Guava objects."/>
</module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
Review comment:
Hmmm, the intention with the original PR is that the classpath would be
set up in such a way that the other subprojects would not be able to see Guava
on their classpath and these imports would give compile errors. @rdblue I guess
you didn't manage to get that working? Perhaps #1067 will fix this? So this
rule shouldn't be necessary and compile errors would give devs a warning
earlier than checkstyle errors. I don't really mind having this as an extra
safety net though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
