waterlx edited a comment on pull request #1077: URL: https://github.com/apache/iceberg/pull/1077#issuecomment-636017685
@rdblue @jerryshao Would you please help to review this PR at your convenience? Regarding UT, I made a separate line to trigger the NPE ``` long actualCount = actual.count() ``` It could be moved into the assert clause at the end, but IMHO a separate line might make it more clear and straightforward ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
