nastra commented on code in PR #8988:
URL: https://github.com/apache/iceberg/pull/8988#discussion_r1384934043
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetConversions.java:
##########
@@ -112,6 +113,10 @@ static Function<Object, Object>
converterFromParquet(PrimitiveType type) {
case FIXED_LEN_BYTE_ARRAY:
case BINARY:
return binary -> ByteBuffer.wrap(((Binary) binary).getBytes());
+ case INT96:
+ return binary ->
+ ParquetUtil.extractTimestampInt96(
+ ByteBuffer.wrap(((Binary)
binary).getBytes()).order(ByteOrder.LITTLE_ENDIAN));
Review Comment:
```suggestion
((Binary)
binary).toByteBuffer().order(ByteOrder.LITTLE_ENDIAN));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
