aokolnychyi commented on code in PR #9000:
URL: https://github.com/apache/iceberg/pull/9000#discussion_r1385766686
##########
core/src/main/java/org/apache/iceberg/BaseRewriteManifests.java:
##########
@@ -242,7 +241,7 @@ private void performRewrite(List<ManifestFile>
currentManifests) {
.executeWith(workerPool())
.run(
manifest -> {
- if (predicate != null && !predicate.test(manifest)) {
+ if (containsDeletes(manifest) || !matchesPredicate(manifest)) {
Review Comment:
Our `BaseRewriteManifests` can rewrite data manifests as well as simply
replace manifests rewritten by an external process. Adding support for directly
rewriting delete manifests is out of scope. The primary and much more scalable
way of rewriting manifests is via an action. This PR focuses purely on the
ability to replace delete manifests rewritten externally that I will consume in
the action.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
