nastra commented on code in PR #8909:
URL: https://github.com/apache/iceberg/pull/8909#discussion_r1387607715
##########
core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java:
##########
@@ -400,8 +400,15 @@ public void
replaceTableViaTransactionThatAlreadyExistsAsView() {
.buildTable(viewIdentifier, SCHEMA)
.replaceTransaction()
.commitTransaction())
- .isInstanceOf(NoSuchTableException.class)
- .hasMessageStartingWith("Table does not exist: ns.view");
+ .satisfiesAnyOf(
+ throwable ->
+ assertThat(throwable)
+ .isInstanceOf(NoSuchTableException.class)
+ .hasMessageStartingWith("Table does not exist: ns.view"),
+ throwable ->
+ assertThat(throwable)
Review Comment:
I actually think that the way Nessie currently handles this error case is
correct by saying that a view with the same name already exists when you try to
create a table. To achieve the same for REST is actually slightly more
difficult. There's also a TODO in the test a few lines above where I wanted to
improve the error reporting for these 2 particular cases that were adjusted in
this test. That being said, I'm +1 on these 2 changes in the test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
