aokolnychyi commented on code in PR #9000:
URL: https://github.com/apache/iceberg/pull/9000#discussion_r1388322693
##########
core/src/test/java/org/apache/iceberg/TestRewriteManifests.java:
##########
@@ -1105,6 +1108,530 @@ public void testRewriteManifestsOnBranchUnsupported() {
"Cannot commit to branch someBranch:
org.apache.iceberg.BaseRewriteManifests does not support branch commits");
}
+ @Test
+ public void testRewriteDataManifestsPreservesDeletes() {
+ Assumptions.assumeThat(formatVersion).isGreaterThan(1);
+
+ Table table = load();
+
+ table.newAppend().appendFile(FILE_A).appendFile(FILE_B).commit();
Review Comment:
One challenge is sometimes we want 2 data commits, sometimes we want 2
delete commits, sometimes one, etc. Also, we capture the snapshot of each
operation. What would be the return value of that method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
