aokolnychyi commented on code in PR #8803:
URL: https://github.com/apache/iceberg/pull/8803#discussion_r1391927184
##########
.palantir/revapi.yml:
##########
@@ -866,6 +866,11 @@ acceptedBreaks:
old: "method void org.apache.iceberg.encryption.Ciphers::<init>()"
new: "method void org.apache.iceberg.encryption.Ciphers::<init>()"
justification: "Static utility class - should not have public
constructor"
+ "1.4.0":
+ org.apache.iceberg:iceberg-core:
+ - code: "java.field.serialVersionUIDChanged"
Review Comment:
While I think it should be fine, here is an idea. Java comes with
`serialver` utility that allows us to generate the version UID prior to the
change in this PR. We can use that value instead of `1L` to be fully
compatible. We don't modify the serialization of this class, we just missed to
assign `serialVersionUID`. If we can recover the default value, we shouldn't
worry about compatibility.
Here is the value I got locally:
```
cd core/build/classes/java/main
serialver org.apache.iceberg.util.SerializableMap
org.apache.iceberg.util.SerializableMap: private static final long
serialVersionUID = -3377238354349859240L;
```
Could you double check, @pvary? If not, we can keep it as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
