aokolnychyi commented on code in PR #8872:
URL: https://github.com/apache/iceberg/pull/8872#discussion_r1395073725
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkStagedScan.java:
##########
@@ -77,14 +77,16 @@ public boolean equals(Object other) {
SparkStagedScan that = (SparkStagedScan) other;
return table().name().equals(that.table().name())
&& Objects.equals(taskSetId, that.taskSetId)
+ && readSchema().equals(that.readSchema())
&& Objects.equals(splitSize, that.splitSize)
&& Objects.equals(splitLookback, that.splitLookback)
&& Objects.equals(openFileCost, that.openFileCost);
}
@Override
public int hashCode() {
- return Objects.hash(table().name(), taskSetId, splitSize, splitSize,
openFileCost);
+ return Objects.hash(
+ table().name(), readSchema(), taskSetId, splitSize, splitSize,
openFileCost);
Review Comment:
Minor: It would be nice to keep the order of values here as the order of
fields in `equals`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
